Fix Fatal error because of missing argument in local_o365\oauth2\systemtoken::instance
#2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `local_o365\oauth2\systemtoken::instance` method, which extends `\local_o365\oauth2\token::instance` was missing the `$forcecreate` argument. Since upgrading to PHP 8.1 this resulted in the following error message: > PHP Fatal error: Declaration of local_o365\oauth2\systemtoken::instance($userid, $tokenresource, local_o365\oauth2\clientdata $clientdata, $httpclient) must be compatible with local_o365\oauth2\token::instance($userid, $tokenresource, local_o365\oauth2\clientdata $clientdata , $httpclient, $forcecreate = false) in /www/local/o365/classes/oauth2/systemtoken.php on line 45 Adding the parameter now to fix the issue.
Fatal error because of missing argument in local_o365\oauth2\systemtoken::instance
|
Hi @AndreasSko The proposed changes have been included in the releases from today. Thank you for your contribution. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the o365 plugin version 4.1.2 with Moodle 4.1. We've recently upgraded our Moodle setup to PHP 8.1. Since then we noticed that some course pages failed to load completely. PHP is logging the following error message:
When debugging the issue we noticed that the following line appears to be missing the
$forcecreateparameter:o365-moodle/local/o365/classes/oauth2/systemtoken.php
Line 45 in 4fb6841
which the token class contains:
o365-moodle/local/o365/classes/oauth2/token.php
Lines 156 to 157 in 4fb6841
By adding the argument to the method we were able to fix that issue. As this is a pretty small change I thought I would already prepare a PR 🙂