This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
fix issue 3549: Broken link on webui #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
reviewed
Oct 10, 2022
| this.setState({ version: res.data }); | ||
| let formatVersion = res.data; | ||
| // 2.0 will get 2.0.0 by node, so delete .0 to get real version | ||
| if (formatVersion.endsWith('.0')) { |
There was a problem hiding this comment.
What if 2.0.11?
Count . in version and split on last .. Or use regex.
There was a problem hiding this comment.
why? 2.0.11 is not end with '.0'. endsWith is enough to judge it, i think.
liuzhe-lz
approved these changes
Oct 11, 2022
ultmaster
approved these changes
Oct 12, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix issue #3549
How to test
test it with package