This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[BugFix] fix compression bugs #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
Louis-J
reviewed
Oct 14, 2022
| @@ -152,8 +152,12 @@ def _get_parent_layers(self, node): | |||
| parent_layers = [] | |||
| queue = [] | |||
| queue.append(node) | |||
| viewed_set = set() | |||
There was a problem hiding this comment.
suggest: other variables to record visited nodes are named 'visited'
| @@ -38,13 +36,13 @@ def forward(self, x): | |||
| from torchvision import datasets, transforms | |||
|
|
|||
| train_loader = torch.utils.data.DataLoader( | |||
| datasets.MNIST(root_path / 'data', train=True, download=True, transform=transforms.Compose([ | |||
| datasets.MNIST('data', train=True, download=True, transform=transforms.Compose([ | |||
| transforms.ToTensor(), | |||
| transforms.Normalize((0.1307,), (0.3081,)) | |||
There was a problem hiding this comment.
yes, magic number for mnist dataset
Louis-J
approved these changes
Oct 18, 2022
|
/azp run fast test |
|
Azure Pipelines successfully started running 1 pipeline(s). |
QuanluZhang
approved these changes
Oct 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depend on #5138
Fixed:
Test Options
Checklist
How to test