This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix the bug that tuner init error does not cause ERROR state #4953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tuner class is initialized before dispatcher connecting to NNI manager. If the initialization failed, dispatcher will never connect to NNI manager.
Therefore, NNI manager cannot detect such failure with PING. This PR adds a timeout on waiting connection to detect this kind of error.
This is a quick fix. In future
setupTuner()should monitor the process' status.Test Options
Checklist
test casedocHow to test