This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
fix total sparsity in sa & auto compress pruner bug #4474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
approved these changes
Jan 18, 2022
| # TODO: replace with validation here | ||
| for config in config_list: | ||
| if 'sparsity' in config or 'sparsity_per_layer' in config: | ||
| _logger.warning('Only `total_sparsity` can be differentially allocate sparse ratio to each layer, `sparsity` or `sparsity_per_layer` will allocate fix sparse ratio to layers. Make sure you know what this will lead to, otherwise please use `total_sparsity`.') |
There was a problem hiding this comment.
There is a grammar problem, please fix it.
There was a problem hiding this comment.
allocate -> allocated, fix -> fixed
zheng-ningxin
approved these changes
Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add warning to SA and auto compress pruner if user set
sparsityorsparsity_per_layer.Fix example & ut bug.
Fix op_names not expand in SA task generator.