This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix v2 level pruner default config bug #4245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-shang
reviewed
Oct 12, 2021
| for config in config_list: | ||
| if 'op_types' in config: | ||
| if 'default' in config['op_types']: | ||
| from ..base.compressor import weighted_modules |
There was a problem hiding this comment.
put this import to the top
…com/Fiascolsy/nni into Fix-v2-level-pruning-default-config
J-shang
reviewed
Oct 12, 2021
| for config in config_list: | ||
| if 'op_types' in config: | ||
| if 'default' in config['op_types']: | ||
| config['op_types'] = weighted_modules |
There was a problem hiding this comment.
please using config['op_types'].remove('default') and config['op_types'].extend(weighted_modules) to avoid:
config = {'op_types': ['default', 'customized_layer']}
J-shang
approved these changes
Oct 13, 2021
QuanluZhang
approved these changes
Oct 13, 2021
78 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could let v2 level pruner work with config_list['op_types'] = 'default'