This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Refactor Hyperopt Tuners (Stage 1) - random tuner #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 tasks
ultmaster
reviewed
Aug 27, 2021
| q: Optional[float] = None | ||
| log_distributed: bool = None | ||
|
|
||
| def is_activated(self, partial_parameters): |
There was a problem hiding this comment.
Could you add some comments on what this is for?
There was a problem hiding this comment.
added informal doc
ultmaster
approved these changes
Sep 3, 2021
QuanluZhang
reviewed
Sep 6, 2021
| from nni.common.hpo_utils import format_search_space, deformat_parameters | ||
| from nni.tuner import Tuner | ||
|
|
||
| class RandomTuner(Tuner): |
There was a problem hiding this comment.
does this tuner still support nested search space?
QuanluZhang
approved these changes
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ultimate goal is to get rid of hyperopt dependency. The code which convert formats between nni and hyperopt is nearly impossible to understand.
4 months ago issue 3534 reported a bug about TPE tuner, but I have absolutely no idea how to debug since then.