This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Refactor NNI Manager UT (Stage 1) - setup toolchain #4109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2021 05:12
78 tasks
J-shang
approved these changes
Aug 27, 2021
| @@ -301,11 +299,11 @@ class NNIRestHandler { | |||
| private getTrialFile(router: Router): void { | |||
| router.get('/trial-file/:id/:filename', async(req: Request, res: Response) => { | |||
| let encoding: string | null = null; | |||
| const filename = req.params.filename; | |||
| const filename = req.params['filename']; | |||
There was a problem hiding this comment.
what's the different between .xxx and ['xxx']
There was a problem hiding this comment.
No difference other than style.
This is required by tsc's strict option noPropertyAccessFromIndexSignature. Because the type of req.params is something like [key: string]: string, instead of filename: string.
SparkSnail
approved these changes
Aug 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.