Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

improve NAS quickstart #4094

Merged
merged 4 commits into from
Sep 10, 2021
Merged

Conversation

QuanluZhang
Copy link
Contributor

No description provided.

@QuanluZhang QuanluZhang marked this pull request as ready for review September 2, 2021 08:25
@QuanluZhang QuanluZhang requested review from ultmaster and scarlett2018 and removed request for ultmaster September 2, 2021 08:25

.. code-block:: python
This example uses two mutation APIs, ``nn.LayerChoice`` and ``nn.ValueChoice``. ``nn.LayerChoice`` takes a list of candidate modules (two in this example), one will be chosen for each sampled model. It can be used like normal PyTorch module. ``nn.ValueChoice`` takes a list of candidate values, one will be chosen to take effect for each sampled model.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing blank line here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? there is blank line before and after this paragraph

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Maybe there is something wrong with my eyes.

self.conv2 = nn.Conv2d(32, 64, 3, 1)
self.dropout1 = nn.Dropout(0.25)
self.dropout2 = nn.Dropout(0.5)
self.fc1 = nn.Linear(9216, 128)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9216 looks like a very large number. You might want to change the conv stride to 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it for now. I will update it when working on retiarii experiment tasks.

@acured acured merged commit 382286d into microsoft:master Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants