This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix interface of CGO's accelerator to support pytorch-lightning 1.4.2 #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
approved these changes
Aug 17, 2021
| plugins: Optional[Union[List[Union[Plugin, ClusterEnvironment, str]], Plugin, ClusterEnvironment, str]] = None): | ||
| plugins: Optional[Union[List[Union[Plugin, ClusterEnvironment, str]], Plugin, ClusterEnvironment, str]] = None, | ||
| **other_trainier_kwargs) -> AcceleratorConnector: | ||
| gpu_ids = Trainer()._parse_devices(gpus, auto_select_gpus, tpu_cores) |
There was a problem hiding this comment.
_parse_devices is a staticmethod, so Trainer._parse_devices is enough.
There was a problem hiding this comment.
I notice _parse_devices of pytorch-lightning 1.4.2 is not staticmethod yet (https://github.com/PyTorchLightning/pytorch-lightning/blob/1.4.2/pytorch_lightning/trainer/trainer.py). Their minor fix of adding staticmethod has not been merged.
There was a problem hiding this comment.
Merged
4 tasks
QuanluZhang
approved these changes
Aug 21, 2021
78 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytorch-lightning updates its interface of TrainingTypePlugin and AcceleratorConnector.
This PR includes: