Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix transformer pruning example #4002

Merged
merged 5 commits into from
Aug 3, 2021
Merged

Fix transformer pruning example #4002

merged 5 commits into from
Aug 3, 2021

Conversation

xiaowu0162
Copy link
Contributor

@xiaowu0162 xiaowu0162 commented Aug 2, 2021 •
edited
Loading

Fixes:

  • config list indentation in example and docs
  • example formatting
  • introduce example in the docs

@xiaowu0162
Copy link
Contributor Author

@zheng-ningxin @J-shang

@xiaowu0162 xiaowu0162 changed the title [Model Compression] fix indentation in transformer example Fix indentation in transformer example Aug 2, 2021
@J-shang J-shang requested a review from zheng-ningxin August 2, 2021 03:32
zheng-ningxin
zheng-ningxin reviewed Aug 2, 2021
View reviewed changes
examples/model_compress/pruning/transformers/transformer_pruning.py
"op_names": [x for layer in attention_name_groups[6:] for x in layer]
}
]
}, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://nni.readthedocs.io/en/latest/Compression/Pruner.html#transformer-head-pruner
I mean the example in the documentation here has the wrong indent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@xiaowu0162
Copy link
Contributor Author

will add fixes for some other issues related to the example

@xiaowu0162 xiaowu0162 marked this pull request as draft August 2, 2021 06:05
@xiaowu0162 xiaowu0162 changed the title Fix indentation in transformer example Fix transformer example Aug 2, 2021
@xiaowu0162 xiaowu0162 changed the title Fix transformer example Fix transformer pruning example Aug 2, 2021
@xiaowu0162 xiaowu0162 marked this pull request as ready for review August 2, 2021 06:44
@QuanluZhang QuanluZhang merged commit e5b4bf1 into microsoft:master Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@QuanluZhang QuanluZhang QuanluZhang approved these changes

@zheng-ningxin zheng-ningxin zheng-ningxin approved these changes

@J-shang J-shang Awaiting requested review from J-shang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaowu0162 @QuanluZhang @J-shang @zheng-ningxin