Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Add simple HPO search space validation #3877

Merged
merged 3 commits into from
Jun 30, 2021
Merged

Conversation

liuzhe-lz
Copy link
Contributor

@liuzhe-lz liuzhe-lz commented Jun 25, 2021

There are multiple issues caused by invalid user search space.
Add a simple validation to make these errors more obvious.

I'm not confident about current implementation, so it only prints an error log and does not interrupt tuner.

@QuanluZhang QuanluZhang requested review from ultmaster and acured June 25, 2021 09:55
'qlognormal',
]

def validate_search_space(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we never use the return value, change "validate_search_space" as void should be ok?

Copy link
Contributor Author

@liuzhe-lz liuzhe-lz Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a public API, the caller might want validation result to decide following action.
For example, I think it's better to integrate validation into tuner API, and then perform early validation in nnictl. In this case, nnictl should halt launching when validation failed, but it won't want to raise the exception to end user.

@liuzhe-lz liuzhe-lz merged commit 32fdd32 into microsoft:master Jun 30, 2021
@liuzhe-lz liuzhe-lz deleted the ss-valid branch June 30, 2021 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants