Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix DNGO tuner class name #3707

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Fix DNGO tuner class name #3707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c26d0b5
Fix DNGO tuner class name
ultmaster Jun 1, 2021
b307dbb
Update tests
ultmaster Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nni/algorithms/hpo/dngo_tuner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def _random_config(search_space, random_state):
return chosen_config


class DngoTuner(Tuner):
class DNGOTuner(Tuner):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, do we update doc accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs were correct in the first place.


def __init__(self, optimize_mode='maximize', sample_size=1000, trials_per_update=20, num_epochs_per_training=500):
self.searchspace_json = None
Expand Down
4 changes: 2 additions & 2 deletions test/ut/sdk/test_builtin_tuners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from unittest import TestCase, main

from nni.algorithms.hpo.batch_tuner import BatchTuner
from nni.algorithms.hpo.dngo_tuner import DngoTuner
from nni.algorithms.hpo.dngo_tuner import DNGOTuner
from nni.algorithms.hpo.evolution_tuner import EvolutionTuner
from nni.algorithms.hpo.gp_tuner import GPTuner
from nni.algorithms.hpo.gridsearch_tuner import GridSearchTuner
Expand Down Expand Up @@ -390,7 +390,7 @@ def test_pbt(self):
self.import_data_test_for_pbt()

def test_dngo(self):
tuner_fn = lambda: DngoTuner(trials_per_update=100, num_epochs_per_training=1)
tuner_fn = lambda: DNGOTuner(trials_per_update=100, num_epochs_per_training=1)
self.search_space_test_all(tuner_fn, fail_types=["choice_str", "choice_mixed",
"normal", "lognormal", "qnormal", "qlognormal"])
self.import_data_test(tuner_fn, stype='choice_num')
Expand Down