This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
AML config v2 #3552
Merged
AML config v2 #3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2021 21:30
SparkSnail
reviewed
Apr 21, 2021
| amlEnvironment.useActiveGpu = this.amlClusterConfig.useActiveGpu; | ||
| amlEnvironment.maxTrialNumberPerGpu = this.amlClusterConfig.maxTrialNumPerGpu; | ||
| amlEnvironment.useActiveGpu = false; | ||
| amlEnvironment.maxTrialNumberPerGpu = 1; |
J-shang
approved these changes
Apr 21, 2021
SparkSnail
reviewed
Apr 21, 2021
| @@ -126,22 +101,24 @@ export class AMLEnvironmentService extends EnvironmentService { | |||
| amlEnvironment.command = `mv envs outputs/envs && cd outputs && ${amlEnvironment.command}`; | |||
| } | |||
| amlEnvironment.command = `import os\nos.system('${amlEnvironment.command}')`; | |||
| amlEnvironment.useActiveGpu = this.amlClusterConfig.useActiveGpu; | |||
| amlEnvironment.maxTrialNumberPerGpu = this.amlClusterConfig.maxTrialNumPerGpu; | |||
| amlEnvironment.useActiveGpu = false; | |||
There was a problem hiding this comment.
does not support setting useActiveGpu?
There was a problem hiding this comment.
Do we really need it? I thought this option does not make sense for AML.
SparkSnail
approved these changes
Apr 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.