Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

put add/remove columns btn to table column endding #3485

Closed
wants to merge 4 commits into from
Closed

put add/remove columns btn to table column endding #3485

wants to merge 4 commits into from

Conversation

Lijiaoa
Copy link
Contributor

@Lijiaoa Lijiaoa commented Mar 28, 2021

before:
image

after:

image

@SparkSnail SparkSnail mentioned this pull request Mar 29, 2021
Closed
78 tasks
@SparkSnail SparkSnail requested review from ultmaster and J-shang March 29, 2021 03:19
ultmaster
ultmaster reviewed Mar 29, 2021
View reviewed changes
ts/webui/src/components/trial-detail/TableList.tsx Outdated
onRender: this._renderOperationColumn.bind(this)
},
{
name: 'setting', // add/remove columns setting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be Setting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Lijiaoa
Copy link
Contributor Author

Lijiaoa commented Mar 29, 2021

  • commit for adjust column width
    for screen little:

image

for screen large:

image

  • commit for setting icon font size
  • add scss file changes for setting icon
  • Looks like it's difficult to add title attribute for setting icon

@Lijiaoa Lijiaoa marked this pull request as draft March 29, 2021 09:51
@Lijiaoa
Copy link
Contributor Author

Lijiaoa commented Apr 6, 2021

Close for better design

@Lijiaoa Lijiaoa closed this Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ultmaster ultmaster ultmaster approved these changes

@J-shang J-shang J-shang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lijiaoa @ultmaster @J-shang