This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add recently-idle environment scheduler in reuse mode #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master
add internal prefix for internal storage methods for clear usage. fix pylint errors minor fixes
rename methods of storageService move trial to a seperated file fix some bugs.
fix openPAI breaking changes
fix minor bugs
to router training service for better understanding.
merge master
trialService is used to support different submission types like AML.
merge master
TrialDispatcher is easier to understand it's purpose.
merge master
merge master
merge master
merge master
merge master
Merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
|
please fix the lint |
94 tasks
QuanluZhang
reviewed
Feb 21, 2021
| @@ -30,7 +30,7 @@ export class GpuScheduler { | |||
|
|
|||
| // private readonly machineExecutorMap: Set<TrialDetail>; | |||
| private readonly log: Logger = getLogger(); | |||
| private readonly policyName: SCHEDULE_POLICY_NAME = 'round-robin'; | |||
| private readonly policyName: SCHEDULE_POLICY_NAME = 'recently-idle'; | |||
There was a problem hiding this comment.
is it possible that only apply this policy for aml training service?
QuanluZhang
reviewed
Feb 21, 2021
| if (selectedEnvironment === undefined) { | ||
| return this.roundRobinSelect(qualifiedEnvironments, allEnvironments); | ||
| } | ||
| selectedEnvironment.latestTrialReleasedTime = -1; |
There was a problem hiding this comment.
BTW, one environment only runs one trial at a time?
There was a problem hiding this comment.
if it is, then policy looks good. if not, one environment can run two trials concurrently, then this policy becomes round robin
There was a problem hiding this comment.
It could run multiple trial at one environment, why it will become round-robin?
QuanluZhang
approved these changes
Feb 24, 2021
fixed. |
J-shang
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.