Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Support dumplicate tensor in the tuple unpack #3340

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

zheng-ningxin
Copy link
Contributor

The input may be reused in the Tuple_constuct node, for example: ['input1', 'input1', 'input2'].
In this case node.inputs will be ['input1', 'input2'] and trigger the assert assert len(node.inputs) == len(list(last_cpp.inputs())), errmsg.
So we use the cpp_node to get the debugName of the inputs.

@zheng-ningxin zheng-ningxin linked an issue Jan 27, 2021 that may be closed by this pull request
@zheng-ningxin zheng-ningxin marked this pull request as draft January 27, 2021 09:57
@zheng-ningxin zheng-ningxin changed the title Fix a bug in tuple unpack. Support dumplicate tensor in the tuple unpack Jan 27, 2021
@mwsunshine
Copy link

hi, ningxin,

I am wondering when will this bug be fixed according to your schedule? Meanwhile, will you release any kind of notification once it is fixed?

@zheng-ningxin zheng-ningxin marked this pull request as ready for review February 2, 2021 01:40
@zheng-ningxin
Copy link
Contributor Author

zheng-ningxin commented Feb 2, 2021

hi, ningxin,

I am wondering when will this bug be fixed according to your schedule? Meanwhile, will you release any kind of notification once it is fixed?

@mwsunshine I guess this PR will be merged in a week and I'll send you a message once merged.

@mwsunshine
Copy link

hi, ningxin,
I am wondering when will this bug be fixed according to your schedule? Meanwhile, will you release any kind of notification once it is fixed?

@mwsunshine I guess this PR will be merged in a week and I'll send you a message once merged.

COOL!
Waiting for your message! So What I should do is to upgrade my nni to the latest version and try to prune the model once again?

@J-shang J-shang merged commit 06e438b into microsoft:master Feb 3, 2021
@mwsunshine
Copy link

hi, ningxin,
I am wondering when will this bug be fixed according to your schedule? Meanwhile, will you release any kind of notification once it is fixed?

@mwsunshine I guess this PR will be merged in a week and I'll send you a message once merged.

hi, ningxin,

I installed the latest nni via source code today, but the error remains. Is it fixed in the latest version? Or I still need to wait for a period of time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export_model does not reduce the size of model.
4 participants