This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix bugs found in integration test #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkSnail
reviewed
Dec 21, 2020
| @@ -15,36 +15,33 @@ jobs: | |||
| echo "##vso[task.setvariable variable=PATH]${PATH}:${HOME}/.local/bin" | |||
| echo "##vso[task.setvariable variable=NNI_RELEASE]999.$(date -u +%Y%m%d%H%M%S)" | |||
|
|
|||
| python3 -m pip install -U --upgrade pip setuptools | |||
| python3 -m pip install -U pytest | |||
| python3 -m pip install --upgrade pip setuptools | |||
There was a problem hiding this comment.
Because it's duplicate to --upgrade.
I mistakenly thought it was --user.
SparkSnail
reviewed
Dec 21, 2020
| displayName: Install customized tuner | ||
|
|
||
| - script: | | ||
| set -e | ||
| docker login -u nnidev -p $(docker_hub_password) | ||
| echo '## Build docker image ##' | ||
| docker build --build-arg NNI_RELEASE=${NNI_RELEASE} -t nnidev/nni-it-pai:latest . | ||
| docker build --build-arg NNI_RELEASE=${NNI_RELEASE} -t nnidev/nni-nightly . |
There was a problem hiding this comment.
Each day scheduled pipelines will build and push several docker images with same content. So it's effectively the nightly version.
I'm planning to write a pipeline to trigger all IT pipelines (after this release), which will build and push docker image at first. This is a preparation for that.
SparkSnail
approved these changes
Dec 21, 2020
ultmaster
approved these changes
Dec 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.