This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
fix file lock bug #3207
Merged
fix file lock bug #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
reviewed
Dec 17, 2020
| @@ -130,4 +130,4 @@ def _release(self): | |||
| return None | |||
|
|
|||
| def get_file_lock(path: string, stale=-1): | |||
| return SimplePreemptiveLock(path + '.lock', stale=-1) | |||
| return SimplePreemptiveLock(path + '.lock', stale=stale) | |||
There was a problem hiding this comment.
have you checked that if you manually create a lock file, does it block new experiment?
There was a problem hiding this comment.
yes, it does not block new experiment. The previous situation was due to always stale=-1, means lock never expires, now fix it.
liuzhe-lz
approved these changes
Dec 18, 2020
QuanluZhang
approved these changes
Dec 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.