This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Retiarii] cross-graph optimization: device placement and input deduplication #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
reviewed
Jun 21, 2021
| learning_rate=learning_rate, weight_decay=weight_decay, optimizer=optimizer) | ||
|
|
||
|
|
||
| class Classification(Lightning): |
There was a problem hiding this comment.
Is it possible to inherit Classification and CgoMixin, to avoid copy all the code.
There was a problem hiding this comment.
It seems to be hard. Most lines of code of Classification and Regression are documentation. The two lines of code in __init__ are both customized for CGO.
ultmaster
reviewed
Jun 21, 2021
nni/retiarii/experiment/pytorch.py
Outdated
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| import atexit | |||
| import logging | |||
| from nni.retiarii.execution.logical_optimizer.logical_plan import PhysicalDevice | |||
There was a problem hiding this comment.
Suggest add shortcut to simplify import
liuzhe-lz
reviewed
Jun 21, 2021
ultmaster
approved these changes
Jul 12, 2021
QuanluZhang
approved these changes
Jul 30, 2021
78 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.