This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix numpy version for Python 3.6 #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-shang
approved these changes
Dec 4, 2020
J-shang
reviewed
Dec 4, 2020
| @@ -77,6 +77,8 @@ | |||
| 'prettytable' | |||
| ] | |||
|
|
|||
| if sys.version_info < (3, 7): | |||
| dependencies[dependencies.index('numpy')] = 'numpy<1.20' | |||
There was a problem hiding this comment.
If we need a limited numpy version anyway, maybe 'numpy<1.19.4' is better? Due to 'numpy >= 1.19.4' have compatibility issue in windows. https://tinyurl.com/y3dm3h86
SparkSnail
approved these changes
Dec 4, 2020
liuzhe-lz
reviewed
Dec 6, 2020
| @@ -77,6 +77,10 @@ | |||
| 'prettytable' | |||
| ] | |||
|
|
|||
| if sys.platform == 'win32': | |||
There was a problem hiding this comment.
This is not the right way. It should depend on the machine installing the wheel, not the machine building the wheel.
https://www.python.org/dev/peps/pep-0508/#environment-markers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.