Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Port markdown docs to rst and introduce "githublink" #3107

Merged
merged 22 commits into from
Dec 10, 2020

Conversation

ultmaster
Copy link
Contributor

@ultmaster ultmaster commented Nov 20, 2020

In this pull request, all the docs will be converted to rst. I will also introduce "githublink". Docs will now be automatically linked to the code/directory that is in the corresponding commit.

Still a few problems to solve:

  • The migration script still cannot resolve all warnings, some of which has been listed as FIXME.
  • All github links need to be rewritten.
  • Will upgrade sphinx to the latest version and eject recommonmark.
  • I'm not sure whether there are potential risks on readthedocs, and integration with crowdin.

@ultmaster ultmaster marked this pull request as ready for review December 4, 2020 04:08
@ultmaster
Copy link
Contributor Author

Let's do an investigation of Chinese docs through PR #3154 first.

@ultmaster ultmaster requested a review from QuanluZhang December 9, 2020 03:17
**y** (array-like, require) - The target values (class labels in classification, real numbers in regression) which shape = [n_samples].

*
**lgb_params** (dict, require) - The parameters for lightgbm model. The detail you could reference `here <https://lightgbm.readthedocs.io/en/latest/Parameters.html>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two underscores?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use only one underscore will produce warnings. I don't fully understand this though.


pruner.export_model(model_path='model.pth')

``mask_dict`` and pruned model in ``onnx`` format(\ ``input_shape`` need to be specified) can also be exported like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backslash?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blackslash is for whitespace. It's converted from markdown. Maybe we can get rid of this later.


* - Tuner
- Brief Introduction of Algorithm
* - `**TPE** <#TPE>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something wrong with the bold font.

Currently, we support the following algorithms:

.. list-table::
:header-rows: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add :widths: auto


In the YAML configure file, you need to set *useAnnotation* to true to enable NNI annotation:

.. code-block:::: bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be two colons.

Usage of Built-in Tuners
------------------------

Using a built-in tuner provided by the NNI SDK requires one to declare the **builtinTunerName** and** classArgs** in the ``config.yml`` file. In this part, we will introduce each tuner along with information about usage and suggested scenarios, classArg requirements, and an example configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank space

classArgs:
optimize_mode: maximize

Note that, to use this tuner, your trial code should be modified accordingly, please refer to `the document of PBTTuner <./PBTTuner>`__ for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is broken.

Built-in Tuner Name: **PPOTuner**


Note that the only acceptable types within the search space are ``layer_choice`` and ``input_choice``. For ``input_choice``\ , ``n_chosen`` can only be 0, 1, or [0, 1]. Note, the search space file for NAS is usually automatically generated through the command `\ ``nnictl ss_gen`` <../Tutorial/Nnictl>`__.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the command \ ``nnictl ss_gen`` <../Tutorial/Nnictl> does not display properly.


* - Name
- Brief Introduction of Algorithm
* - `Level Pruner <https://nni.readthedocs.io/en/latest/Compression/Pruner.html#level-pruner>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolute path? Not just in this doc

Copy link
Contributor

@kvartet kvartet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete the folderarchive_en_US?

@ultmaster
Copy link
Contributor Author

Should we delete the folderarchive_en_US?

Let's keep it and delete it before release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants