Fix develop install #3060
Fix develop install #3060
Conversation
| @@ -132,6 +133,7 @@ def prepare_nni_node(): | |||
| node_src = Path('toolchain/node', node_executable_in_tarball) | |||
| node_dst = Path('nni_node', node_executable) | |||
| shutil.copyfile(node_src, node_dst) | |||
| os.chmod(node_dst, os.stat(node_dst).st_mode | stat.S_IEXEC) | |||
There was a problem hiding this comment.
shutil.copymode() should be better.
|
Empty |
| @@ -164,7 +164,7 @@ def run(self): | |||
|
|
|||
| class Develop(develop): | |||
| def finalize_options(self): | |||
| self.user = True # always use `develop --user` | |||
| self.user = False # always use `develop --user` | |||
There was a problem hiding this comment.
I suggest to explicitly check conda/venv/virtualenv.
Pip will not fallback to --user when python directory is protected, and the error message will not hint to do so either.
If you don't want to do the check anyway, just remove this function. Forcing to False will make it impossible to install as normal user without venv.
@liuzhe-lz I added them because on my machine, nnictl cannot be installed at all because |
|
@liuzhe-lz will open a separate PR to resolve comments (and some other issues, possibly). 👍 |
How did you install it? For develop mode it just creates an egg link to top level nni folder and there should be nothing to do with "install nnictl". |
|
The issue has been fixed in #3063. |
No description provided.