Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[Retiarii] Base execution engine, codegen and trainer #3059

Merged
merged 5 commits into from
Nov 5, 2020

Conversation

ultmaster
Copy link
Contributor

@ultmaster ultmaster commented Nov 3, 2020

I had a painful time trying to installing NNI on my machine. Let's fix the NNI installation first because testing this PR.

Test: nnictl create --config nni.yaml


Attributes
----------
send_trial_callback
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why send_trial() has a callback?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK. Maybe execution engine wants to use it somehow?

Let's keep that in mind and maybe remove it in future...

@QuanluZhang QuanluZhang merged commit 002af91 into microsoft:dev-retiarii Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants