This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Chevron icon before table row and TableList refactoring #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
these items had fixed by ultmaster:
|
Lijiaoa
reviewed
Oct 9, 2020
| minWidth: columnWidth * 4, | ||
| maxWidth: columnWidth * 10, | ||
| isResizable: true, | ||
| onColumnClick: this._onColumnClick.bind(this), |
There was a problem hiding this comment.
when page auto refresh, these trials sorted status will be reset. so you could use this function in render(): example
Comment on lines
55
to
59
| if (a[key] === undefined) { | ||
| return 1; | ||
| } | ||
| if (b[key] === undefined) { | ||
| return -1; |
There was a problem hiding this comment.
because default metric column may be NaN | Infinity or others, so you should change it back. example
There was a problem hiding this comment.
Updated and refactored this part. Please check.
There was a problem hiding this comment.
Please check the number column sort: duration and default metric.
|
Lijiaoa
reviewed
Oct 10, 2020
| class ExpandableDetails extends React.Component<ExpandableDetailsProps, ExpandableDetailsState> { | ||
| constructor(props: ExpandableDetailsProps) { | ||
| super(props); | ||
| this.state = { isExpand: false }; |
There was a problem hiding this comment.
seems like that you don't use this.state.isExpand
Comment on lines
288
to
289
| minWidth: columnWidth * 4, | ||
| maxWidth: columnWidth * 10, |
There was a problem hiding this comment.
you can try this size:
minWidth: columnWidth * 13,
maxWidth: columnWidth * 18,
liuzhe-lz
approved these changes
Oct 14, 2020
Lijiaoa
approved these changes
Oct 14, 2020
QuanluZhang
approved these changes
Oct 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will do in this PR.
Should fix (high prior):
Should test:
Known issues (low pri):
s[0]undefined in Compare when closing sometimes.