-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Conversation
I don't think we should silently follow |
The other tools have two different options:
I'm fine with both of them. If you are more comfortable with option 2, let's go ahead with option 2. As for implementation, I tried using |
There could be scenarios like the user copies a 3rd-party library, which is git-ignored, into codeDir and they will get confused when the experiment fails. |
Okay, I can remove the gitignore part. But first, let's discuss it in tomorrow's meeting, to see if there are any other concerns. |
export function* listDirWithIgnoredFiles(root: string, relDir: string, ignoreFiles: string[]): Iterable<string> { | ||
let ignoreFile = undefined; | ||
const source = path.join(root, relDir); | ||
if (fs.existsSync(path.join(source, '.nniignore'))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will check .nniignore file in every subfolder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Works like .gitignore.
Design:
Code dir validation is moved to nnictl..nniignore
is first checked,if it doesn't exist, then fallback to.gitignore
..git
folder is still not ignored. If users intend to ignore this folder, use.nniignore
.Future work:
nnictl should prepare a snapshot, nni experiment should have the option to use the snapshot directly, instead of using a codeDir.TODO: