Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Add support for zero gpuNum in kubernetes #1830

Merged
merged 1 commit into from
Dec 10, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,16 @@ abstract class KubernetesTrainingService {

// tslint:disable:no-any
public generatePodResource(memory: number, cpuNum: number, gpuNum: number): any {
return {
const resources: any = {
memory: `${memory}Mi`,
cpu: `${cpuNum}`,
'nvidia.com/gpu': `${gpuNum}`
cpu: `${cpuNum}`
};

if (gpuNum !== 0) {
resources['nvidia.com/gpu'] = `${gpuNum}`;
}

return resources;
} // tslint:enable:no-any

public async listTrialJobs(): Promise<TrialJobDetail[]> {
Expand Down Expand Up @@ -265,7 +270,7 @@ abstract class KubernetesTrainingService {
// Refer https://github.com/NVIDIA/k8s-device-plugin/issues/61
// So we have to explicitly set CUDA_VISIBLE_DEVICES to empty if user sets gpuNum to 0 in NNI config file
if (gpuNum === 0) {
nvidiaScript = `export CUDA_VISIBLE_DEVICES='0'`;
nvidiaScript = 'export CUDA_VISIBLE_DEVICES=';
}
// tslint:disable-next-line: strict-boolean-expressions
const nniManagerIp: string = this.nniManagerIpConfig ? this.nniManagerIpConfig.nniManagerIp : getIPV4Address();
Expand Down