This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Unify nas searchspace #1393
Merged
Unify nas searchspace #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 tasks
QuanluZhang
approved these changes
Jul 31, 2019
|
@Crysple great job! please update the search space spec doc accordingly |
xuehui1991
approved these changes
Aug 1, 2019
| @@ -7,7 +7,9 @@ def random_archi_generator(nas_ss, random_state): | |||
| ''' | |||
| chosen_archi = {} | |||
| print("zql: nas search space: ", nas_ss) | |||
| for block_name, block in nas_ss.items(): | |||
| for block_name, block_value in nas_ss.items(): | |||
| assert block_value['_type'] == "mutable_layer", "Random NAS Tuner only receives NAS search space" | |||
There was a problem hiding this comment.
why not point out we need "mutable_layer" key here.
There was a problem hiding this comment.
I have modify the info to explicitly pointed this out
Have added. Please help review |
66 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_type-- "mutable_type"