Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[fix issue#1332] Double check for trial does not have final result in webui #1350

Merged
merged 4 commits into from
Jul 25, 2019
Merged

[fix issue#1332] Double check for trial does not have final result in webui #1350

merged 4 commits into from
Jul 25, 2019

Conversation

lvybriage
Copy link
Contributor

@suiguoxin
Copy link
Member

@ultmaster

@suiguoxin suiguoxin self-requested a review July 24, 2019 02:59
@ultmaster
Copy link
Contributor

I'm kind of confused. The bug seems to be fixed, but the interface looks like this in case there is no final result.

image

As you see, the default metrics in the bottom shows FINAL (but I didn't submit FINAL result); so if it is FINAL for real, why is it not shown on the hyper-parameter chart?

To reproduce this test, you only need to comment one line here and rerun MNIST as instructed:

nni/examples/trials/mnist/mnist.py

Line 207 in a5fa235

nni.report_final_result(test_acc)

Maybe I made some mistake; contact me if needed.

@lvybriage
Copy link
Contributor Author

@ultmaster I'll continue to fix this confuse in detail table. If trial's status is succeed, and it haven't final result, will show that xxx (LATEST).

@lvybriage
Copy link
Contributor Author

image

@ultmaster
Copy link
Contributor

Issue fixed. @suiguoxin

@suiguoxin suiguoxin merged commit 8fd3cf0 into microsoft:master Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@suiguoxin suiguoxin suiguoxin approved these changes

@QuanluZhang QuanluZhang QuanluZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lvybriage @suiguoxin @ultmaster @QuanluZhang