This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix bug of nnictl about stopping experiment and update statsmodels version to v0.9.1.1 #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leckie-chn
reviewed
Jul 15, 2019
leckie-chn
suggested changes
Jul 15, 2019
There was a problem hiding this comment.
local test failed with:
nnictl stop QPuLxnU1
Traceback (most recent call last):
File "/home/niyan/.local/bin/nnictl", line 10, in <module>
sys.exit(parse_args())
File "/home/niyan/.local/lib/python3.6/site-packages/nni_cmd/nnictl.py", line 215, in parse_args
args.func(args)
File "/home/niyan/.local/lib/python3.6/site-packages/nni_cmd/nnictl_utils.py", line 219, in stop_experiment
experiment_id_list = parse_ids(args)
File "/home/niyan/.local/lib/python3.6/site-packages/nni_cmd/nnictl_utils.py", line 154, in parse_ids
elif args.all == 'all':
AttributeError: 'Namespace' object has no attribute 'all'
Sorry for making a mistake when copying code. |
leckie-chn
approved these changes
Jul 15, 2019
QuanluZhang
approved these changes
Jul 15, 2019
leckie-chn
pushed a commit
to leckie-chn/nni
that referenced
this pull request
Jul 17, 2019
…rsion to v0.9.1.1 (microsoft#1297) * update statsmodel for bohb * fix nnictl stop experiment bug * fix nnictl stop experiment bug * fix nnictl stop experiment bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1
issue #1098
incompatability between scipy and statsmodel --> refer to this issue
since statsmodel has been updated from 0.9.0 to 0.10.0
2
issue #1292
there's a bug about nnictl stop experiment in this PR #1216 .
allremains an option in args innnictl.pybut is used as a boolean value innnictl_utils.py