This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
support multi-phase in hyperband #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuehui1991
reviewed
Jul 5, 2019
| elif data['type'] == 'PERIODICAL': | ||
| self.brackets[s].set_config_perf( | ||
| int(i), data['parameter_id'], data['sequence'], value) | ||
| if data['type'] == 'REQUEST_PARAMETER': |
There was a problem hiding this comment.
abstract these command into a command(class instead of using string)?
| self.completed_hyper_configs.append(data) | ||
| elif data['type'] == 'PERIODICAL': | ||
| self.brackets[bracket_id].set_config_perf(int(i), data['parameter_id'], data['sequence'], value) | ||
| if data['type'] == 'REQUEST_PARAMETER': |
| # and PERIODICAL metric are independent, thus, not comparable. | ||
| self.brackets[bracket_id].set_config_perf(int(i), data['parameter_id'], sys.maxsize, value) | ||
| self.completed_hyper_configs.append(data) | ||
| elif data['type'] == 'PERIODICAL': |
| value = extract_scalar_reward(data['value']) | ||
| bracket_id, i, _ = data['parameter_id'].split('_') | ||
| bracket_id = int(bracket_id) | ||
| if data['type'] == 'FINAL': |
44 tasks
chicm-ms
reviewed
Jul 10, 2019
| # if there is no running parameter_id, self.job_id_para_id_map[trial_job_id] == None | ||
| # new trial job is added to this dict and finished trial job is removed from it. | ||
| self.job_id_para_id_map = dict() | ||
|
|
||
| def load_checkpoint(self): | ||
| pass |
There was a problem hiding this comment.
load_checkpoint and save_checkpoint can be removed if they are empty.
chicm-ms
reviewed
Jul 10, 2019
| self.job_id_para_id_map = dict() | ||
| # record the unsatisfied parameter request from trial jobs | ||
| self.unsatisfied_jobs = [] | ||
|
|
||
| def load_checkpoint(self): | ||
| pass |
There was a problem hiding this comment.
load_checkpoint and save_checkpoint can be removed if they are empty.
xuehui1991
approved these changes
Jul 12, 2019
| reward = -value | ||
| else: | ||
| reward = value | ||
| assert 'parameter_id' in data |
There was a problem hiding this comment.
you could assert after 591 line.
chicm-ms
approved these changes
Jul 12, 2019
66 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.