This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Validate file name in codeDir for PAI platform #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix remote bug (microsoft#523)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Fix yaml package in setup.py (microsoft#1006)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master from Microsoft
merge master
merge V0.8
merge master
Add sklearn installation in setup.py (microsoft#1157)
merge master
QuanluZhang
reviewed
Jun 14, 2019
| try { | ||
| fileCount = await countFilesRecursively(codeDir); | ||
| fileNameValid = await validateFileNameRecursively(codeDir); | ||
| } catch(error) { | ||
| throw new Error(`Call count file error: ${error}`); |
There was a problem hiding this comment.
this error message is not proper any more. Suggest to do countFile and validateFile one by one separately.
There was a problem hiding this comment.
fixed, validate filename and filecount separately.
QuanluZhang
reviewed
Jun 14, 2019
src/nni_manager/common/utils.ts
Outdated
| try { | ||
| if (fs.lstatSync(fullFilePath).isFile()) { | ||
| result = validateFileName(fileName); | ||
| } else { |
There was a problem hiding this comment.
also need to validate directory's name?
There was a problem hiding this comment.
fixed, validate directory name.
QuanluZhang
approved these changes
Jun 19, 2019
chicm-ms
approved these changes
Jun 19, 2019
merge master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1164