Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Nested search space refinement #1048

Merged
merged 49 commits into from
May 16, 2019
Merged

Conversation

leelaylay
Copy link
Contributor

@leelaylay leelaylay commented May 5, 2019

  1. Change the directory structure (move some common class and function to utils.py)
  2. Add unit test for evolution_tuner, hyperopt_tuner and utils.
  3. HyperoptTuner (Random, Anneal, TPE) and EvolutionTuner support new format of nested search space.

One simple json example follows as below.

{
    "layer0": {
        "_name": "Avg_pool",
        "pooling_size": 3
    },
    "layer1": {
        "_name": "Conv",
        "kernel_size": 2
    },
    "layer2": {
        "_name": "Empty"
    },
    "layer3": {
        "_name": "Conv",
        "kernel_size": 5
    }
}

related to issue #1028 .

Lee Joe added 30 commits February 19, 2019 23:58
# Conflicts:
#	src/sdk/pynni/nni/metis_tuner/metis_tuner.py
# Conflicts:
#	src/sdk/pynni/nni/metis_tuner/metis_tuner.py
@PurityFan
Copy link
Contributor

PurityFan commented May 6, 2019

Well done! BTW, why Grid Search can't support nested dict?

@PurityFan
Copy link
Contributor

Can you add the doc for nested dict in SearchSpaceSpec.html ?

@xuehui1991 xuehui1991 requested review from xuehui1991 and PurityFan May 6, 2019 03:56
@leelaylay
Copy link
Contributor Author

Can you add the doc for nested dict in SearchSpaceSpec.html ?

  1. OK, I will add the doc for nested dict layer in SearchSpaceSpec.doc.
  2. Grid Search and some other tuners didn't seem to support this feature originally. (Maybe we can support it later?)

@xuehui1991
Copy link
Contributor

Can you add the doc for nested dict in SearchSpaceSpec.html ?

  1. OK, I will add the doc for nested dict layer in SearchSpaceSpec.doc.
  2. Grid Search and some other tuners didn't seem to support this feature originally. (Maybe we can support it later?)

For the original version, only those tuners based on hyperopt support nested search space.

@QuanluZhang
Copy link
Contributor

code refactor looks good, thanks

@xuehui1991 xuehui1991 merged commit 5af0154 into microsoft:master May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants