This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAI quota management #1021
PAI quota management #1021
Changes from 84 commits
d77a99c
695d866
b7e9799
7cb03f9
44d1565
7ab7386
d9e1ea8
2c225a8
be23f55
6f760ab
9161209
e661c55
4e5d836
f80e737
aefc219
4fec2cc
dc45661
11fec6f
a03a191
7c7832c
2c862dc
85c015d
85cb472
3784355
d91c980
9786650
ef176d2
1089e80
627e823
b633c26
035d58b
cd549df
964743a
8422992
40391ec
1d84526
1852457
754a354
1ee9735
9f4485c
b1c3774
5d7923e
281f3dc
2ce9157
571a7af
f09d51a
41a9a59
21165b5
d25f7b5
17e719e
e25ffbd
5e777d2
6ff24a5
ccf6c04
eb5e21c
f796c60
e1ae623
ec41d56
080ae00
f0a2d39
77526d3
d95c351
346d49d
6af4b86
cf5336d
aec4977
b1dfaff
6c9360a
0663218
5187b2c
5032694
edf6b3b
01904eb
5951a63
439dfb7
03be709
3a3bfb9
c577553
0f57ca0
2f83c6b
7976205
c18ac6c
0aa038d
93d6502
b5eab4b
f39d69e
d2c7c8f
a030505
c7ca451
df2f99b
40bae6e
a2617b6
c5acd8c
0b85482
ccad629
dc2cd24
9f1fef7
a684a64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the meaning of return
{}
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return a None type or an empty dict if got error, changed to use
None
, more easy to understand.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to show why failed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use <root_path>/* ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we want to show the details of deleting process, so we do not delete root_path directly, instead we traverse the paths under root_path, and show the paths to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this function return false if delete failed, but do not give error message and do not throw any exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok