Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FF-A] Notification Service Updates #339

Conversation

Raymond-MS
Copy link

Description

Updated the ID and Bitmap values to UINT32s.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Tested with the FfaPartitionTestApp

Integration Instructions

N/A

@Raymond-MS Raymond-MS requested a review from kuqin12 February 13, 2025 22:10
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Feb 13, 2025
@@ -32,7 +32,7 @@ PeCoffLoaderRelocateImageExtraAction (
IN OUT PE_COFF_LOADER_IMAGE_CONTEXT *ImageContext
)
{
#ifdef __GNUC__
#ifdef __GNUC__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i dont think you need to change this. the tool is too nice to run on all files :)

@Raymond-MS Raymond-MS force-pushed the personal/rdiaz/notification_update branch from 044945b to 212cf38 Compare February 14, 2025 20:01
@Raymond-MS Raymond-MS merged commit fc8f6fd into microsoft:feature/ffa_enablement Feb 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants