Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crate dependencies to use crates.io #619

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

makubacki
Copy link
Member

@makubacki makubacki commented Jan 16, 2025

Description

Move from git dependencies to those from crates.io.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

  • Local build and test

Integration Instructions

  • N/A

@makubacki makubacki self-assigned this Jan 16, 2025
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jan 16, 2025
Move from git dependencies to those from crates.io.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki force-pushed the use_crates_io_crates branch from 0913983 to 1a8281d Compare January 16, 2025 21:03
@github-actions github-actions bot added the type:backport Backport changes in a dev branch PR to its release branch. label Jan 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.59%. Comparing base (3c4318e) to head (1a8281d).
Report is 3 commits behind head on dev/202405.

Additional details and impacted files
@@              Coverage Diff               @@
##           dev/202405     #619      +/-   ##
==============================================
+ Coverage        9.82%   11.59%   +1.76%     
==============================================
  Files             132      132              
  Lines           21387    21561     +174     
  Branches         2546     2546              
==============================================
+ Hits             2102     2499     +397     
- Misses          18959    19028      +69     
+ Partials          326       34     -292     
Flag Coverage Δ
AdvLoggerPkg 6.07% <ø> (ø)
HidPkg 2.80% <ø> (+0.67%) ⬆️
MfciPkg 41.21% <ø> (+20.21%) ⬆️
MsCorePkg 1.44% <ø> (ø)
MsWheaPkg 7.25% <ø> (+2.05%) ⬆️
XmlSupportPkg 27.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makubacki makubacki requested a review from Javagedes January 16, 2025 21:29
@makubacki makubacki enabled auto-merge (squash) January 16, 2025 22:17
@makubacki makubacki merged commit 32dcdcc into microsoft:dev/202405 Jan 16, 2025
30 checks passed
ProjectMuBot pushed a commit that referenced this pull request Jan 16, 2025
## Description

Move from git dependencies to those from crates.io.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

- Local build and test

## Integration Instructions

- N/A

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants