HidPkg/UsbHidDxe: Continue on failure to get descriptor #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case a HID device fails to return a HID descriptor, this change will return the error status from UsbHidDriverBindingStart() rather than assert to match previous behavior from HID drivers. The HID IO protocol will not be installed on these devices. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
f324242 to
11bf6a6
Compare
|
+@joschock for visibility. We discussed this offline to reduce the stringency on devices outside keyboards and mice that we don't believe were strictly probed for HID reports before. |
5 tasks
apop5
approved these changes
Oct 17, 2023
kuqin12
approved these changes
Oct 17, 2023
joschock
approved these changes
Oct 17, 2023
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Oct 18, 2023
Introduces 2 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/1824154a50aca7449f0a174a08a85b563df34c0b">182415</a> Repo File Sync: Update to Mu DevOps 7.0.1 and Rust 1.73.0 (<a href="https://github.com/microsoft/mu_plus/pull/333">#333</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/2cc586da022edb231ee1f377531d8e1ec0e32530">2cc586</a> HidPkg/UsbHidDxe: Continue on failure to get descriptor (<a href="https://github.com/microsoft/mu_plus/pull/334">#334</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case a HID device fails to return a valid HID descriptor, this change
will return the error status from UsbHidDriverBindingStart() rather
than assert to match previous behavior from HID drivers that required
the boot protocol. The HID IO protocol will not be installed on these
devices.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
not blocking boot.
Integration Instructions
Update to a Mu Plus release with this change.