Only call HdwPortWrite if DebugLevel Met

[os-d]

Description

The DebugLevel is checked twice in the hot path on serial path writes and the HdwPortWrite call is made even if the upper layer knows that the message being logged does not meet the DebugLevel criteria.

Closes #309.

In order to maintain backwards compatibility, if the LoggerInfo block is found to have a version less than the hardware logging level version, the PCD is checked to decide whether to call HdwPortWrite or not.

In SEC, because we may not have the LoggerInfo structure, we check the PCD to see if the message should be logged at this DebugLevel.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

• Impacts functionality?
  • Functionality - Does the change ultimately impact how firmware functions?
  • Examples: Add a new library, publish a new PPI, update an algorithm, ...
• Impacts security?
  • Security - Does the change have a direct security impact on an application,
    flow, or firmware?
  • Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
• Breaking change?
  • Breaking change - Will anyone consuming this change experience a break
    in build or boot behavior?
  • Examples: Add a new library class, move a module to a different repo, call
    a function in a new library class in a pre-existing module, ...
• Includes tests?
  • Tests - Does the change include any explicit test code?
  • Examples: Unit tests, integration tests, robot tests, ...
• Includes documentation?
  • Documentation - Does the change contain explicit documentation additions
    outside direct code modifications (and comments)?
  • Examples: Update readme file, add feature readme file, link to documentation
    on an a separate Web page, ...

How This Was Tested

Build tested.

Integration Instructions

If a bespoke AdvLoggerHdwPortLib is used, AdvLoggerHdwPortWrite should not check DebugLevel, but simply write the message to the hardware port.

[apop5]

The intention of this second Pcd was to allow PcdFixedDebugPrintErrorLevel and PcdAdvancedLoggerHdwPortDebugPrintErrorLevel to both function independently. The debug messages written into the advanced logger memory buffer would be based on the PcdFixedDebugPrintErrorLevel and the debug messages actually written out to a hardware port could be less (since the writes to some things, like serial ports, can be much slower than copying into a memory buffer).

Are you intending to remove this feature?

[os-d]

The intention of this second Pcd was to allow PcdFixedDebugPrintErrorLevel and PcdAdvancedLoggerHdwPortDebugPrintErrorLevel to both function independently. The debug messages written into the advanced logger memory buffer would be based on the PcdFixedDebugPrintErrorLevel and the debug messages actually written out to a hardware port could be less (since the writes to some things, like serial ports, can be much slower than copying into a memory buffer).

Are you intending to remove this feature?

This is not intended to remove that feature. PcdAdvancedLoggerHdwPortDebugPrintErrorLevel is still checked (it is loaded into LoggerInfo->HwPrintLevel). This just avoids checking this twice (once in AdvancedLoggerLib, once in AdvancedLoggerHdwPortLib) and avoids calling into AdvancedLoggerHdwPortLib when we know we won't be logging anyway.

In the legacy case, where the new code has loaded a LoggerInfo that doesn't have the HwPrintLevel field in it, we'll check the PCD explicitly.