Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsGraphicsPkg/FrameBufferMemDrawLib: Fix function declaration mismatch #282

Merged

Conversation

makubacki
Copy link
Member

Description

Fixes the following issues with GetGraphicsInfo().

  1. Removes EFIAPI. This is an internal function to the library
    implementation and the explicit calling convention is not needed.
    In turn, this makes the function prototype in the C files match
    the header file.
  2. Add an include guard to the local library header file.

Resolves the following GCC warning:

MsGraphicsPkg/Library/FrameBufferMemDrawLib/FrameBufferMemDrawLib.h:16:1:
warning: type of ‘GetGraphicsInfo’ does not match original declaration [-Wlto-type-mismatch]
16 | GetGraphicsInfo (
| ^

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

CI build.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Aug 9, 2023
@makubacki makubacki requested review from os-d and apop5 August 9, 2023 14:04
Fixes the following issues with `GetGraphicsInfo()`.

1. Removes `EFIAPI`. This is an internal function to the library
   implementation and the explicit calling convention is not needed.
   In turn, this makes the function prototype in the C files match
   the header file.
2. Add an include guard to the local library header file.

Resolves the following GCC warning:

  MsGraphicsPkg/Library/FrameBufferMemDrawLib/FrameBufferMemDrawLib.h:16:1:
  warning: type of ‘GetGraphicsInfo’ does not match original declaration [-Wlto-type-mismatch]
    16 | GetGraphicsInfo (
       | ^

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki force-pushed the fix_framebuffermemdrawlib_issues branch from ae196de to e69632a Compare August 9, 2023 22:57
@makubacki makubacki merged commit 546a06c into microsoft:release/202302 Aug 10, 2023
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Aug 16, 2023
Introduces 7 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_plus/commit/bd77aef2e0ea5bdf22ddd9070811b9e5c875e67f">bd77ae</a> Repo File Sync: Update to Mu DevOps 5.0.6 and Ubuntu container 3bf70b5 (<a href="https://github.com/microsoft/mu_plus/pull/278">#278</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/365843ca00fd406d6e03e40be11883ebd7094078">365843</a> Add a check on the `PcdAdvancedFileLoggerFlush` for exit boot services (<a href="https://github.com/microsoft/mu_plus/pull/277">#277</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/e3527a304392a00fea08b39ab885529cd542d898">e3527a</a> pip: bump edk2-pytool-extensions from 0.23.9 to 0.23.10 (<a href="https://github.com/microsoft/mu_plus/pull/279">#279</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/25aedad81d6b72cd4d85b9653f62a742061f0db9">25aeda</a> PcBdsPkg: Fix previous CodeQL change (51c7dc2) (<a href="https://github.com/microsoft/mu_plus/pull/280">#280</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/519500d7b211e8f5cbcd2c9075b88e80a2dff65a">519500</a> pip: bump edk2-pytool-library from 0.15.3 to 0.16.1 (<a href="https://github.com/microsoft/mu_plus/pull/284">#284</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/8e93f0dfc998c80a05c66be32de53759a908908c">8e93f0</a> pip: bump regex from 2023.6.3 to 2023.8.8 (<a href="https://github.com/microsoft/mu_plus/pull/283">#283</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/546a06cd8175b35f5f22cca2233c1445abe4bb83">546a06</a> MsGraphicsPkg/FrameBufferMemDrawLib: Fix function declaration mismatch (<a href="https://github.com/microsoft/mu_plus/pull/282">#282</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants