Added logic to delete the Memory Type Information variable on a capsule update. #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuqin12
approved these changes
Jul 6, 2023
makubacki
reviewed
Jul 7, 2023
… of https://github.com/kenlautner/mu_plus into personal/klautner/delete_memory_info_variable_on_flash
makubacki
reviewed
Jul 7, 2023
makubacki
approved these changes
Jul 7, 2023
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jul 15, 2023
Introduces 5 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/c1e8984a25bf488937f15324da7aeb391b93a283">c1e898</a> pip: bump edk2-pytool-extensions from 0.23.6 to 0.23.8 (<a href="https://github.com/microsoft/mu_plus/pull/270">#270</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/1e7d11ac550fb0b14703ac90f0edc7a385ff660b">1e7d11</a> ci.yaml: add PrEval entry (<a href="https://github.com/microsoft/mu_plus/pull/267">#267</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/0497c22cad9468a419bbae95fef534375cefd5d6">0497c2</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_plus/pull/272">#272</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/2b1bfcd5076ec877b558c3d6ae25079d6ef83564">2b1bfc</a> Added logic to delete the Memory Type Information variable on a capsule update. (<a href="https://github.com/microsoft/mu_plus/pull/271">#271</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/51c7dc24efa24e7cf01afb823ccd14aa11257fd4">51c7dc</a> [CHERRY-PICK] Fix CodeQL errors (<a href="https://github.com/microsoft/mu_plus/pull/274">#274</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added logic to delete the Memory Type Information variable on a capsule update. This is because in rare circumstance where a new memory type is added (or a memory type is removed) a capsule update will cause a mismatch of memory types. Removing the variable and thus forcing a clean memory bucket discovery solves this issue.
For each item, place an "x" in between
[and]if true. Example:[x].(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Tested on a platform where there is a capsule update between two versions of firmware with a different amount of memory types. Without this change the transition from temp ram to permanent memory breaks but with this change the device correctly goes to the default memory bucket configuration and is able to boot.
Integration Instructions
N/A