Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test | Fix random test issues with BVT Test #994

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Test | Fix random test issues with BVT Test #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
947fd0a
Fix random test issues with BVT Test
cheenamalhotra Mar 19, 2019
84d7b5b
Remove unwanted truncation
cheenamalhotra Mar 21, 2019
400453c
Order rows
cheenamalhotra Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/java/com/microsoft/sqlserver/jdbc/bvt/BvtTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ public void testCreatepreparedStatement() throws SQLException {

String colName = table1.getEscapedColumnName(7);
String value = table1.getRowData(7, 0).toString();
String query = "SELECT * from " + table1.getEscapedTableName() + " where " + colName + " = ? ";
String query = "SELECT * from " + table1.getEscapedTableName() + " where " + colName + " = ? "+ " ORDER BY " + table1.getEscapedColumnName(0);

try (DBConnection conn = new DBConnection(connectionString);
DBPreparedStatement pstmt = conn.prepareStatement(query)) {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/microsoft/sqlserver/testframework/DBResultSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ public void verifydata(int ordinal, Class<?> coercion, Object expectedData, Obje

case java.sql.Types.TIME:
String retrievedTime = retrieved.toString();
String expectedTime = expectedData.toString().substring(0, retrievedTime.length());
String expectedTime = expectedData.toString();
assertTrue(expectedTime.equalsIgnoreCase(retrievedTime),
"Unexpected time value, expected: " + expectedTime + " ,received: " + retrievedTime);
break;
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/microsoft/sqlserver/testframework/sqlType/SqlTime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public SqlTime() {
public Object createdata() {
Time temp = new Time(
ThreadLocalRandom.current().nextLong(((Time) minvalue).getTime(), ((Time) maxvalue).getTime()));
String timeNano = temp.toString() + "." + generateRandomInt(this.scale);
String timeNano = temp.toString();
return timeNano;

// can pass String rather than converting to loacTime, but leaving it
Expand Down