Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to perform JUnit testing against Azure DW #903

Merged
merged 22 commits into from
Dec 18, 2018

Conversation

peterbae
Copy link
Contributor

@peterbae peterbae commented Dec 5, 2018

Command to perform only Azure DW Test:

mvn clean install -DtestGroup=AzureDWTest
(and you also need to either provide the mssql_jdbc_test_connection_properties environment variable yourself, or modify that variable in the AbstractTest.java file)

This test can be performed along with the build42/build43 profiles.

The regular JUnit test has about ~450 test cases, so the Azure DW test suite currently tests about 25% of the regular JUnit test plan, and this number will be brought up in the near future.

Added test results screenshots to the PR.

test1
test2

@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #903 into dev will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #903      +/-   ##
============================================
- Coverage     48.68%   48.54%   -0.14%     
+ Complexity     2817     2808       -9     
============================================
  Files           118      118              
  Lines         27882    27882              
  Branches       4642     4642              
============================================
- Hits          13574    13536      -38     
- Misses        12119    12159      +40     
+ Partials       2189     2187       -2
Flag Coverage Δ Complexity Δ
#JDBC42 48.11% <ø> (-0.06%) 2768 <ø> (-5)
#JDBC43 48.43% <ø> (-0.19%) 2801 <ø> (-13)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 40.65% <0%> (-6.6%) 13% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.55% <0%> (-0.98%) 256% <0%> (-9%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.14% <0%> (-0.87%) 42% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.19% <0%> (-0.77%) 0% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.99% <0%> (-0.44%) 89% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.57% <0%> (-0.12%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.66% <0%> (+0.23%) 255% <0%> (+2%) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 54.41% <0%> (+1.47%) 12% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.77% <0%> (+1.51%) 110% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6bae75...6ba5bac. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.4 milestone Dec 6, 2018
@cheenamalhotra
Copy link
Member

Please pull changes from peterbae#6

@ulvii
Copy link
Contributor

ulvii commented Dec 17, 2018

Remove unused imports.

…ure-DW-Junit

# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/TestResource.java
#	src/test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java
cheenamalhotra
cheenamalhotra previously approved these changes Dec 17, 2018
…ure-DW-Junit

# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/bvt/BvtTest.java
#	src/test/java/com/microsoft/sqlserver/testframework/AbstractTest.java
lilgreenbird added a commit to lilgreenbird/mssql-jdbc that referenced this pull request Dec 18, 2018
@peterbae peterbae merged commit 7c804bc into microsoft:dev Dec 18, 2018
lilgreenbird added a commit that referenced this pull request Dec 25, 2018
* ported tests from VSO and added tests to increase code coverage

* moved resultset tests to resultset

* removed unused import

* added tests to increase code coverage

* fixed issue with timezone

* fixed issue with timezone

* modified testWithThaiLocale to use current time

* fixed issue with timezone

* fixed issue with timezone

* fixed issue with timezone

* added SparseTest and BigIntegerTest and cleaned up with try-with-resources

* review changes

* review comments

* more review updates

* review updates

* removed dummy file

* review udpates

* more cleanup

* updated isSqlAzure

* review updates

* more review updates

* fixed imports

* updated failed error strings with more detail

* added locale to time format

* format date for comparision

* 1 more timezone fix

* cleanup leaded stream resources

* manually merged with #903 changes for now

* more cleanup on assertEqual checks

* more cleanup on assertEqual checks

* cosmetic changes from review

* updated all assertEquals params to proper expected, actual order

* fixed comments and leaked resultsets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants