Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the issue template #779

Merged
merged 3 commits into from
Aug 28, 2018
Merged

Updating the issue template #779

merged 3 commits into from
Aug 28, 2018

Conversation

ulvii
Copy link
Contributor

@ulvii ulvii commented Aug 8, 2018

I made a few minor changes to the template. Please let me know if you have any other suggestions.

## Repro code
Please share repro code with us, or tell us how to reproduce the issue.
## Driver version or JAR name
Please tell us what the JDBC driver version or JAR name is.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be worded as: "Please mention the version of JDBC Driver client application is running with."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add examples of what it should look like maybe?

For Example:
JDBC Driver Version: 7.00
JDBC Driver Name: mssql-jdbc-7.0.0-SNAPSHOT.jre10

Please tell us what the JDBC driver version or JAR name is.

## SQL Server version
Please tell us what the SQL Server version is.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please mention version of Microsoft SQL Server in use."

Please tell us what should happen and what happens instead.
## Repro code
Please share a repro code with us.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please share a standalone Java code that reproduces the issue."

Please tell us the table schema.

## Problem description
Please share more details with us.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please describe issue in full detail"

Please tell us what Operating System the client application is running on.

## Java/JVM version
Example: java version "1.8.0", IBM J9 VM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide version of JVM client application runs with. (eg. java version "10.0.1")

peterbae
peterbae previously approved these changes Aug 27, 2018
@codecov-io
Copy link

codecov-io commented Aug 28, 2018

Codecov Report

Merging #779 into dev will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #779      +/-   ##
============================================
- Coverage     48.17%   48.14%   -0.03%     
- Complexity     2776     2783       +7     
============================================
  Files           116      116              
  Lines         27854    27862       +8     
  Branches       4636     4641       +5     
============================================
- Hits          13418    13415       -3     
- Misses        12215    12227      +12     
+ Partials       2221     2220       -1
Flag Coverage Δ Complexity Δ
#JDBC42 47.7% <ø> (ø) 2744 <ø> (+9) ⬆️
#JDBC43 48.02% <ø> (ø) 2777 <ø> (+8) ⬆️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.47% <0%> (-1.48%) 11% <0%> (-1%)
...r/jdbc/SQLServerAeadAes256CbcHmac256Algorithm.java 70.54% <0%> (-0.89%) 11% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.14% <0%> (-0.87%) 42% <0%> (-1%)
...SQLServerColumnEncryptionJavaKeyStoreProvider.java 63.12% <0%> (-0.52%) 10% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.46% <0%> (-0.34%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.61% <0%> (-0.16%) 135% <0%> (-1%)
...osoft/sqlserver/jdbc/SQLServerSpatialDatatype.java 85.38% <0%> (ø) 290% <0%> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.48% <0%> (+0.19%) 5% <0%> (+1%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.61% <0%> (+0.38%) 255% <0%> (+7%) ⬆️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.25% <0%> (+0.43%) 87% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e301555...98221f8. Read the comment docs.

peterbae
peterbae previously approved these changes Aug 28, 2018
rene-ye
rene-ye previously approved these changes Aug 28, 2018
@ulvii ulvii dismissed stale reviews from rene-ye and peterbae via 98221f8 August 28, 2018 22:19
@ulvii ulvii merged commit cdd4b80 into microsoft:dev Aug 28, 2018
@ulvii ulvii deleted the IssueTemplate branch August 28, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants