Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push 6.5.1-preview into master #671

Merged
merged 27 commits into from
Apr 7, 2018
Merged

Push 6.5.1-preview into master #671

merged 27 commits into from
Apr 7, 2018

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented Apr 6, 2018

Push changes for release

rPraml and others added 27 commits November 20, 2017 21:34
ADD: Testcase to show broken java.sql.Time support
…d return their own type code, not VARBYTE. also removing unused imports.
Removing unused imports
Also updating a couple of old MSDN links.
Adding release roadmap and standards info
655 Fix to return correct column type for spatial datatypes
* Dont throw exception for colmetadata token

* Adding a comment

* Update comment

* Adding a warning message

* remove ignoreLengthPrefixedToken
* Added more information to error messages

To help debug an irreproducable/random mismatch error if it occurs in the future.

* Revert "Added information to error message"

This reverts commit 25301e6.

* Fix for #659

Added error handling logic for special cases.

* Read message length

Read the message length instead of reading until terminating character

* Unsigned byte update

Message length is an unsigned byte, converting before using.

* Removed clunky hex conversions

convert the byte straight to an int and use existing constants instead of making new ones

* Narrowed trigger conditions

fixed an issue where column names who had the hex token 'AA' would cause an error to be thrown.

* Spacing fixes

* Added test case

* spacing adjustment

* Edited test drop procedures

Changed IF EXISTS DROP commands to be compatible with sql server 2008

* github spacing misalignment fixes

* Changed test condition

now only runs on compatible database or higher

* Removed error check

Removed a previous implementation in favor of one that changes the TDS parser

* tdsreader change

* removing test for now

* enabled tests

* github spacing fix

* removed array import

* removed "arrays" instead of "array"

* spacing changes
* Added more information to error messages

To help debug an irreproducable/random mismatch error if it occurs in the future.

* Fix for the issue when using setMaxRows() with SHOWPLAN ON (#666)

* Dont throw exception for colmetadata token

* Adding a comment

* Update comment

* Adding a warning message

* remove ignoreLengthPrefixedToken

* Fix for uncaught/unhandled exception (#664)

* Added more information to error messages

To help debug an irreproducable/random mismatch error if it occurs in the future.

* Revert "Added information to error message"

This reverts commit 25301e6.

* Fix for #659

Added error handling logic for special cases.

* Read message length

Read the message length instead of reading until terminating character

* Unsigned byte update

Message length is an unsigned byte, converting before using.

* Removed clunky hex conversions

convert the byte straight to an int and use existing constants instead of making new ones

* Narrowed trigger conditions

fixed an issue where column names who had the hex token 'AA' would cause an error to be thrown.

* Spacing fixes

* Added test case

* spacing adjustment

* Edited test drop procedures

Changed IF EXISTS DROP commands to be compatible with sql server 2008

* github spacing misalignment fixes

* Changed test condition

now only runs on compatible database or higher

* Removed error check

Removed a previous implementation in favor of one that changes the TDS parser

* tdsreader change

* removing test for now

* enabled tests

* github spacing fix

* removed array import

* removed "arrays" instead of "array"

* spacing changes

* Use Socket instead of SocketChannel when multiSubnetFailover=true (#662)

* Upped SQL Server requirement to 2017

* Removing Exception Test

Implement a more generic and compatible test in the future

* Removed imports

Used in removed test
* Added more information to error messages

To help debug an irreproducable/random mismatch error if it occurs in the future.

* Fix for the issue when using setMaxRows() with SHOWPLAN ON (#666)

* Dont throw exception for colmetadata token

* Adding a comment

* Update comment

* Adding a warning message

* remove ignoreLengthPrefixedToken

* Fix for uncaught/unhandled exception (#664)

* Added more information to error messages

To help debug an irreproducable/random mismatch error if it occurs in the future.

* Revert "Added information to error message"

This reverts commit 25301e6.

* Fix for #659

Added error handling logic for special cases.

* Read message length

Read the message length instead of reading until terminating character

* Unsigned byte update

Message length is an unsigned byte, converting before using.

* Removed clunky hex conversions

convert the byte straight to an int and use existing constants instead of making new ones

* Narrowed trigger conditions

fixed an issue where column names who had the hex token 'AA' would cause an error to be thrown.

* Spacing fixes

* Added test case

* spacing adjustment

* Edited test drop procedures

Changed IF EXISTS DROP commands to be compatible with sql server 2008

* github spacing misalignment fixes

* Changed test condition

now only runs on compatible database or higher

* Removed error check

Removed a previous implementation in favor of one that changes the TDS parser

* tdsreader change

* removing test for now

* enabled tests

* github spacing fix

* removed array import

* removed "arrays" instead of "array"

* spacing changes

* Use Socket instead of SocketChannel when multiSubnetFailover=true (#662)

* Upped SQL Server requirement to 2017

* Removing Exception Test

Implement a more generic and compatible test in the future

* Removed imports

Used in removed test

* Change in preperation for 6.5.1 preview release

* Removed SNAPSHOT from POM

* Added missing link

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md
@rene-ye rene-ye requested a review from cheenamalhotra April 6, 2018 23:26
@codecov-io
Copy link

codecov-io commented Apr 6, 2018

Codecov Report

Merging #671 into master will increase coverage by 0.2%.
The diff coverage is 54.16%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #671     +/-   ##
===========================================
+ Coverage     48.08%   48.29%   +0.2%     
- Complexity     2577     2582      +5     
===========================================
  Files           113      113             
  Lines         26574    26587     +13     
  Branches       4429     4436      +7     
===========================================
+ Hits          12777    12839     +62     
+ Misses        11680    11619     -61     
- Partials       2117     2129     +12
Flag Coverage Δ Complexity Δ
#JDBC42 48.23% <54.16%> (+0.21%) 2579 <0> (+4) ⬆️
#JDBC43 48.22% <54.16%> (+0.22%) 2578 <0> (+4) ⬆️
Impacted Files Coverage Δ Complexity Δ
...a/com/microsoft/sqlserver/jdbc/SQLJdbcVersion.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Geography.java 69.53% <ø> (ø) 33 <0> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/Geometry.java 71.09% <ø> (ø) 33 <0> (ø) ⬇️
...osoft/sqlserver/jdbc/SQLServerSpatialDatatype.java 87.43% <ø> (ø) 266 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 67.54% <25%> (-0.93%) 0 <0> (ø)
...oft/sqlserver/jdbc/SQLServerResultSetMetaData.java 40.93% <57.14%> (-0.04%) 24 <0> (+1)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.14% <60%> (+0.05%) 245 <0> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.26% <62.5%> (+1.39%) 0 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 46.06% <0%> (ø) 17% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39.4% <0%> (+0.21%) 43% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b5904...03c6617. Read the comment docs.

@cheenamalhotra cheenamalhotra merged commit 6f46660 into master Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants