-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process all responses before proceed and fix retry logic for metadata caching #436
Process all responses before proceed and fix retry logic for metadata caching #436
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #436 +/- ##
============================================
+ Coverage 46.25% 46.32% +0.06%
+ Complexity 2200 2197 -3
============================================
Files 108 108
Lines 25210 25215 +5
Branches 4164 4166 +2
============================================
+ Hits 11662 11680 +18
+ Misses 11519 11507 -12
+ Partials 2029 2028 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #436 +/- ##
============================================
- Coverage 46.25% 46.21% -0.05%
- Complexity 2200 2201 +1
============================================
Files 108 108
Lines 25210 25235 +25
Branches 4164 4176 +12
============================================
Hits 11662 11662
- Misses 11519 11555 +36
+ Partials 2029 2018 -11
Continue to review full report at Codecov.
|
Hello @TobiasSQL , we know you are very busy, but if you could have a few minutes to take a look at this PR, it would be very helpful to us. Thank you 😃 |
return true; | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method hasNextPacket()
content can be compressed to:
return (null!=currentPacket.next);
} | ||
else { | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method endOfCurrentPacket()
content can be compressed to:
return (payload == currentPacket.payloadLength);
Things to verify for this fix:
|
close it due to new PR #543 |
fix 2 issues in the driver related to metadata caching.
The issues are found by replacing
throw
withraiserror
in the test, in order to run the test against SQL Server 2008Repo code for first issue:
try_issue.txt
Another issue happens when using batching. The data is inserted/updated more times than expected.