Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove volatile keyword #409

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

xiangyushawn
Copy link
Contributor

for issue #191

@codecov-io
Copy link

codecov-io commented Jul 25, 2017

Codecov Report

Merging #409 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #409   +/-   ##
=========================================
  Coverage     44.98%   44.98%           
+ Complexity     2133     2130    -3     
=========================================
  Files           107      107           
  Lines         24661    24661           
  Branches       4102     4102           
=========================================
  Hits          11093    11093           
- Misses        11711    11712    +1     
+ Partials       1857     1856    -1
Flag Coverage Δ Complexity Δ
#JDBC41 44.78% <100%> (+0.02%) 2121 <0> (ø) ⬇️
#JDBC42 44.79% <100%> (-0.01%) 2122 <0> (-5)
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.75% <100%> (+0.17%) 0 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 76.42% <0%> (-1.63%) 29% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 39.55% <0%> (-0.68%) 84% <0%> (-2%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.61% <0%> (-0.44%) 90% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 59.31% <0%> (-0.35%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.57% <0%> (-0.31%) 138% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.42% <0%> (-0.22%) 46% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 77.23% <0%> (-0.17%) 4% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.41% <0%> (+0.36%) 248% <0%> (+5%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9e78e...cb696aa. Read the comment docs.

@xiangyushawn xiangyushawn merged commit 97ab207 into microsoft:dev Aug 11, 2017
@xiangyushawn xiangyushawn deleted the volatile-fields-fix branch August 11, 2017 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants