Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert const char[] to char[] to avoid conversion warnings #337

Merged
merged 3 commits into from
Mar 23, 2017
Merged

convert const char[] to char[] to avoid conversion warnings #337

merged 3 commits into from
Mar 23, 2017

Conversation

yukiwongky
Copy link
Contributor

@yukiwongky yukiwongky commented Mar 23, 2017 •
edited by Hadis-Fard
Loading

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 55.388% when pulling 6b2aa39 on v-kaywon:string_warning into 7434d06 on Microsoft:dev.

@yukiwongky yukiwongky requested a review from ulvii March 23, 2017 17:45
Hadis-Fard
Hadis-Fard reviewed Mar 23, 2017
View reviewed changes
source/sqlsrv/init.cpp Outdated
SQLSRV_G( warnings_return_as_errors ) = INI_BOOL( INI_PREFIX INI_WARNINGS_RETURN_AS_ERRORS );
// need to convert const char[] to char[] to avoid converting string to char* warnings
// cannot simply cast const char[] to char* since INI_INT needs the sizeof(param) and the size of char* is always 4 / 8 bytes
char warnings_as_errors[] = INI_PREFIX INI_WARNINGS_RETURN_AS_ERRORS;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentations 😄

@yukiwongky
Update init.cpp
b4f7684 
fix indentation
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 55.388% when pulling b4f7684 on v-kaywon:string_warning into 7434d06 on Microsoft:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 55.412% when pulling 9f3c0ce on v-kaywon:string_warning into 7434d06 on Microsoft:dev.

@yukiwongky yukiwongky merged commit bd8d1e1 into microsoft:dev Mar 23, 2017
@yukiwongky yukiwongky deleted the string_warning branch June 30, 2017 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hadis-Fard Hadis-Fard Hadis-Fard approved these changes

@ulvii ulvii ulvii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yukiwongky @coveralls @Hadis-Fard @ulvii