Issue 228. sqlsrv ClientBufferMaxKBSize setting - positive integer. #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new tests for sqlsrv and pdo.
v-kigos
approved these changes
Jan 25, 2017
yitam
reviewed
Jan 26, 2017
| @@ -592,7 +592,7 @@ PHP_FUNCTION( sqlsrv_configure ) | |||
|
|
|||
| zend_long buffered_query_limit = Z_LVAL_P( value_z ); | |||
|
|
|||
| CHECK_CUSTOM_ERROR( buffered_query_limit < 0, error_ctx, SQLSRV_ERROR_INVALID_BUFFER_LIMIT, _FN_ ) { | |||
There was a problem hiding this comment.
Should we update the MSDN doc to specify that buffer size limit must be positive? Just a suggestion.
| echo ("Number of rows: $numRows\n"); | ||
|
|
||
| $size = 3; | ||
| $stmt = $conn->prepare("SELECT * FROM ".$dbName.".[dbo].[php_test_table_2]", array(constant('PDO::ATTR_CURSOR') => PDO::CURSOR_SCROLL,PDO::SQLSRV_ATTR_CURSOR_SCROLL_TYPE => PDO::SQLSRV_CURSOR_BUFFERED,PDO::SQLSRV_ATTR_CLIENT_BUFFER_MAX_KB_SIZE=> $size)); |
There was a problem hiding this comment.
Please explain why the buffer sizes are different for table 1 and table 2
There was a problem hiding this comment.
the data retrieval is different for varchar(max) and varchar(1000).
A slightly bigger buffer is needed for varchar(max) to work even if inserted data is the same.
| fetchData($conn, $dbName.".[dbo].[php_test_table_2]", $size); // this should return 0 rows. | ||
| // set client buffer size to 2KB | ||
| $size = 2; | ||
| fetchData($conn, $dbName.".[dbo].[php_test_table_1]", $size); // this should return 1 row. |
There was a problem hiding this comment.
Is the client buffer size requirement 2KB due to UTF-8 char set? It's not clear in this test alone
There was a problem hiding this comment.
The total column length is > 1024 since it's varchar(1036).
|
Please merge this code into 'merged-codebase' branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sqlsrv check that ClientBufferMaxKBSize is a positive integer.
Add new tests for sqlsrv and pdo.