Issue#192 #201
Merged
Issue#192 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set to utf8. See issue microsoft#192
Hadis-Fard
suggested changes
Dec 13, 2016
| else { | ||
| // If encoding is set to UTF-8, the following types are not necessarily column size. | ||
| // We need to call SQLGetData with c_type SQL_C_WCHAR and set the size accordingly. | ||
| if ( encoding == SQLSRV_ENCODING( CP_UTF8 )) { |
There was a problem hiding this comment.
it is better to use SQLSRV_ENCODING_UTF8 syntax instead of SQLSRV_ENCODING( CP_UTF8 )
Hadis-Fard
approved these changes
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue with buffered result sets.
When connection option is set to utf8, we cannot assume that local code page matches the server collation. Need to call SQLGetData with target c type set to SQL_C_WCHAR.