5.7.0-preview merge #1031

david-puglielli · 2019-09-05T21:03:53Z

No description provided.

Dev

Fixed the potential error reported by Prefast code analysis

Use SQLSRV_ASSERT for checking NULL ptrs

For these AKV tests check env despite not AE connected

Added the driver option to run functional tests

Fixed connection pooling tests for more than one ODBC drivers

* Added the driver argument to getDSN * Dropped the driver argument but set to null as default * Removed the AE condition in locale support * Modified the AE condition for locale support

* Version 5.3.0 * Fixed the wrong replacements * Added comments block to m4 files * Use dnl for comments

… loop through php types (#801) * Modified AE fetch phptypes test to insert only one row at a time and loop through php types * Fixed formatting

* Streamlined two very similar large column name tests * Changed the EOL

* Updates to change log and readme * Dropped support for Ubuntu 17 * Modified as per review comments

… 17.2

* Updated instructions and sample test for 5.3.0 RTW * Fixed sample code to adhere to php coding standard * Fixed cases and spaces * Modified NOTE for UB 18.04 based on review comments * Added 'exit' * Modified change log and readme based on review to PR 811 * Applied review comments

Odbc 172 update for connres and appveyor

* Streamlined two very similar large column name tests * Added random number of test table names to avoid operand clash issues * Replaced to with for based on review

Issue 909 fix

Issue #432 fix

…stead (#995)

* Removed unneeded constants * Fixed sqlsrv_free_stmt argument info * Fixed brace escape to avoid buffer overflow * Fixed brace escape and added test * Debugging test failure on Bamboo * Removed debugging output * Debugging test failure on Bamboo * Removed debugging output * Added more test cases * Changed range check to use strchr * Added pdo test * Fixed test and formatting

…de for coveralls (#1020)

coveralls · 2019-09-05T21:24:35Z

Coverage increased (+1.08%) to 73.418% when pulling cc844fd on david-puglielli:master into 5dabd47 on microsoft:master.

codecov-io · 2019-09-05T21:32:29Z

Codecov Report

Merging #1031 into master will decrease coverage by 1.69%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1031     +/-   ##
=========================================
- Coverage   80.49%   78.79%   -1.7%     
=========================================
  Files          25       25             
  Lines        7758     8146    +388     
=========================================
+ Hits         6245     6419    +174     
- Misses       1513     1727    +214

Impacted Files	Coverage Δ
...vc14/x86/php-7.1.29-src/ext/pdo_sqlsrv/pdo_dbh.cpp
...x86/php-7.1.29-src/ext/sqlsrv/shared/core_init.cpp
...php-7.1.29-src/ext/pdo_sqlsrv/shared/core_util.cpp
...c14/x86/php-7.1.29-src/ext/pdo_sqlsrv/pdo_util.cpp
...php-7.1.29-src/ext/pdo_sqlsrv/php_pdo_sqlsrv_int.h
...x86/php-7.1.29-src/ext/sqlsrv/shared/core_conn.cpp
...x86/php-7.1.29-src/ext/sqlsrv/shared/core_stmt.cpp
...php-7.1.29-src/ext/pdo_sqlsrv/shared/core_sqlsrv.h
...x86/php-7.1.29-src/ext/sqlsrv/shared/core_util.cpp
...6/php-7.1.29-src/ext/sqlsrv/shared/core_stream.cpp
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dabd47...cc844fd. Read the comment docs.

david-puglielli and others added 30 commits March 31, 2017 18:01

Merge pull request #1 from Microsoft/dev

16c41e0

Dev

Fixed the potential error reported by Prefast code analysis

10ff344

Merge pull request #788 from yitam/fillLastID

3585bf5

Fixed the potential error reported by Prefast code analysis

Use SQLSRV_ASSERT for checking NULL ptrs

44d1bb3

Merge pull request #789 from yitam/moreAsserts

5a66610

Use SQLSRV_ASSERT for checking NULL ptrs

For these AKV tests check env despite not AE connected

f6e450b

Merge pull request #791 from yitam/fixODBC13tests

90c6443

For these AKV tests check env despite not AE connected

Added the driver option to run functional tests

071e897

Merge pull request #793 from yitam/addDriverOption

ea6381c

Added the driver option to run functional tests

Fixed connection pooling tests for more than one ODBC drivers

17fa64a

added driver option to pdo isPooled.php

d554492

Merge pull request #796 from yitam/connPooltests

53e4da4

Fixed connection pooling tests for more than one ODBC drivers

Removed win32 ifdefs re connection resiliency (#802)

81ff085

Set the driver argument for getDSN to null by default (#798)

eeea787

* Added the driver argument to getDSN * Dropped the driver argument but set to null as default * Removed the AE condition in locale support * Modified the AE condition for locale support

Changed int to SQLLEN to avoid infinite loop (#806)

ae0b95b

Version 5.3.0 (#803)

197489a

* Version 5.3.0 * Fixed the wrong replacements * Added comments block to m4 files * Use dnl for comments

Modified AE fetch phptypes test to insert only one row at a time and…

aef3830

… loop through php types (#801) * Modified AE fetch phptypes test to insert only one row at a time and loop through php types * Fixed formatting

Streamlined two very similar large column name tests (#807)

5aa9be7

* Streamlined two very similar large column name tests * Changed the EOL

Updates to change log and readme (#811)

bbfe6df

* Updates to change log and readme * Dropped support for Ubuntu 17 * Modified as per review comments

Fixed connection resiliency tests for Unix, updated AppVeyor for ODBC…

af9f77e

… 17.2

Fixed expected output

b2f7b20

Fixed output and skipifs

82be814

Fixed skipifs and output

0495513

Fixed driver name

c1d5793

build output to debug appveyor failure

a18a59b

removed debug output

cb78977

Merge pull request #814 from david-puglielli/odbc-172-update

9479d03

Odbc 172 update for connres and appveyor

Streamlined two very similar large column name tests (#815)

35631cf

* Streamlined two very similar large column name tests * Added random number of test table names to avoid operand clash issues * Replaced to with for based on review

Changelog updated

706c526

david-puglielli and others added 26 commits May 13, 2019 11:14

Corrected formatting

1aa8dea

Replaced EXPECTF with EXPECT

60f20bd

Merge pull request #990 from david-puglielli/issue-909-fix

e152459

Issue 909 fix

Merge pull request #989 from david-puglielli/issue-432-fix

f369ce6

Issue #432 fix

Fixed two failing tests (#991)

7e0bf91

Redesigned some tests based on recent test results (#992)

ac59cfd

Modified pipelines to connect using sqlcmd inside of the container in…

9122c15

…stead (#995)

Added batch query

68d7903

Added batch query test for pdo (#997)

7c585c7

Added a new test and modify a non LOB sqlsrv test (#1000)

ec3a7a4

Two index zval functions are macros in php 7.4 (#1001)

a092523

Replaced uint with size_t (#1004)

5c42829

Check compiler version for php 74 (#1005)

d4387a9

Fixed tests that failed in php 7.4 (#1006)

c0cf381

Improve data caching with datetime objects (#1008)

b839ede

Addressed various issues with PHP 7.4 beta1 (#1015)

65daa7a

Updated dockerfile to use UB 18.04 and PHP 73 (#1016)

31a7748

Added survey results (#1017)

c1bc593

Updated ODBC driver 17.4 (#1019)

bae6930

Modified output.py to take a new argument and travis yml to use inclu…

aa03782

…de for coveralls (#1020)

Used constants in memory stress tests for easier configuration (#1022)

eb8ecbf

Removed KSP related scripts and files (#1030)

f5c0b63

Updated version to 5.7.0 preview (#1029)

2792ece

Change log for 5.7.0 (#1028)

fdf029d

5.7.0-preview

cc844fd

yitam changed the title ~~Master~~ 5.7.0-preview merge Sep 5, 2019

yitam merged commit bd06cf3 into microsoft:master Sep 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

5.7.0-preview merge #1031

5.7.0-preview merge #1031

david-puglielli commented Sep 5, 2019

coveralls commented Sep 5, 2019

codecov-io commented Sep 5, 2019 •

edited

Loading

5.7.0-preview merge #1031

5.7.0-preview merge #1031

Conversation

david-puglielli commented Sep 5, 2019

coveralls commented Sep 5, 2019

codecov-io commented Sep 5, 2019 • edited Loading

Codecov Report

codecov-io commented Sep 5, 2019 •

edited

Loading